Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enthalpy_pred_types that predict T seem to be missing T on edge? #444

Open
zingale opened this issue May 6, 2024 · 0 comments
Open

enthalpy_pred_types that predict T seem to be missing T on edge? #444

zingale opened this issue May 6, 2024 · 0 comments

Comments

@zingale
Copy link
Member

zingale commented May 6, 2024

If you look at the code in MaestroEnthalpyAdvance.cpp, we do:

  // needs to be done after the state was returned to the full state.
  if ((enthalpy_pred_type == predict_T_then_rhohprime) ||
       (enthalpy_pred_type == predict_T_then_h) ||
       (enthalpy_pred_type == predict_Tprime_then_h)) {
       `(sedge, rho0_edge_old, rhoh0_edge_old, rho0_edge_new,
                     rhoh0_edge_new);
  }

but in HfromRhoTedge, it is not clear where we are getting the temperature from.

In the original MAESTRO, we passed in the temperature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant