Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically detect port from env #17

Open
5HT2 opened this issue Oct 6, 2021 · 1 comment
Open

Automatically detect port from env #17

5HT2 opened this issue Oct 6, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@5HT2
Copy link
Member

5HT2 commented Oct 6, 2021

Currently, you must edit both config/.env and docker-compose.yml to change the port of a Docker container. This is confusing to the user (and to me, when I forget about it).

Grabbing the port from config/.env would be ideal.

Currently we have HB_ADDR=0.0.0.0:6060, which is part of what we need. We could make the 6060 part a HB_PORT variable in config/.env if Docker supports expanding env vars.

Testing it needed to ensure if this is possible.

@5HT2 5HT2 added the enhancement New feature or request label Oct 6, 2021
@5HT2
Copy link
Member Author

5HT2 commented Oct 6, 2021

I did 2f93848, which doesn't entirely solve things (two variables inside config/.env), but at least you only have to edit one file now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant