Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple token support #11

Open
5HT2 opened this issue Sep 29, 2021 · 6 comments
Open

Multiple token support #11

5HT2 opened this issue Sep 29, 2021 · 6 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@5HT2
Copy link
Member

5HT2 commented Sep 29, 2021

Possible, some way to configure a token for each device. As mentioned in #10

@5HT2 5HT2 added the enhancement New feature or request label Sep 29, 2021
@Not-Super-Nova
Copy link
Contributor

Idea on how to implement:
New DB field, "authkeys", and is stored as follows

{
    "deviceName": "sha512 hash of key, salted with device name",
    "etc": "etc"
}

Would be easy enough to implement API calls to insert and remove devices, and you could avoid keeping any actual keys in the database in case it gets compromised.

@5HT2 5HT2 added the question Further information is requested label Dec 18, 2022
@5HT2
Copy link
Member Author

5HT2 commented Dec 18, 2022

Should just be done as part of rust rewrite? Re: @karaiwulf

@karaiwulf
Copy link

The rust rewrite is very much incomplete, but it's located here.
Basically, most of the endpoints, while defined, are little nothing's. And there's no database connection.
I ended up losing hyperfocus on it while deciding what I wanted to use for the database connection.

But yes I agree, multiple token support should be implemented. And as a later thing, probably some sort of pgp or ssh key signature mechanism as well.

@5HT2
Copy link
Member Author

5HT2 commented Dec 18, 2022

I'd like to switch to postgresql, see #31. I'll probs end up rewriting heartbeat in rust myself or fork your version

@karaiwulf
Copy link

I hadn't actually checked the issues to know that, but I was absolutely gonna use psql as the backend, since I've been having issues with the redis persistence on the illumos platform.

@5HT2
Copy link
Member Author

5HT2 commented Dec 19, 2022

I'm glad you're not the only one struggling with persistence rofl
It's been so fucking annoying honestly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants