Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring consistency in support for the Timestamp data type format in different statements. #3875

Open
gaoboal opened this issue Apr 15, 2024 · 1 comment
Labels
enhancement New feature or request sql SQL standard. definition/revise for a SQL statement/clause etc

Comments

@gaoboal
Copy link
Collaborator

gaoboal commented Apr 15, 2024

Describe the feature you'd like

Currently, there is inconsistency in the support for the Timestamp data type format across statements such as insert, select, and load data infile. Furthermore, the documentation lacks comprehensive descriptions in this regard.
Some test cases and examples: https://qiok3h8ob4.feishu.cn/docx/P1LBdzVIeoPSuHxUUBBcgGq9n7c?from=from_copylink

Desired Improvements

  1. Support for String Format Timestamps
    Implement support for Timestamps in string format, including parsing, validation, and support for millisecond-level precision. The expected format is: yyyy-MM-dd HH:mm:ss.SS.

  2. Support for int64 Format Timestamps
    Extend support to include Timestamps in int64 format.

  3. Conversion Support with timestamp Function
    Allow conversion between string/int64 format Timestamps using the timestamp function.

  4. Consistent Behavior for Timestamp Columns with Indexes
    Ensure uniform behavior when dealing with Timestamp columns that have indexes.

By implementing these improvements, we aim to enhance consistency and usability across various statements and operations involving Timestamp data types.

@aceforeverd
Copy link
Collaborator

#3731: unify row encode impl with codegen row builder, gives consistent and most widely supported format

@aceforeverd aceforeverd added enhancement New feature or request sql SQL standard. definition/revise for a SQL statement/clause etc labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request sql SQL standard. definition/revise for a SQL statement/clause etc
Projects
None yet
Development

No branches or pull requests

2 participants