Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to make binderhub software allowed to read if an image is available in quay.io #4342

Closed
consideRatio opened this issue Jul 3, 2024 · 0 comments · Fixed by #4344
Closed

Comments

@consideRatio
Copy link
Member

consideRatio commented Jul 3, 2024

Attempt to fix #4315, practically by using extraVolumes and extraVolumeMounts config introduced from 2i2c-org/binderhub-service#122, in order to mount the k8s Secret created by the binderhub-service chart when configuring buildPodsRegistryCredentials.

The name of the secret to mount should be named something like small-binder-binderhub-service-build-pods-docker-config, and you can configure the location it was mounted to be detected by binderhub via binderhub-service.config.DockerRegistry.docker_config_path.

Testing of this can be done in opensci's small binderhub, where its verified by building a repo twice and the second time it doesn't do a build at all but just launches, after success, we should update all hubs using quay.io in the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant