You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for submission. Good job with Tip Calculator 👍
Quick Comments:
NSUserDefaults is global. You don't need to pass it from one screen to another screen. This is one of the methods to pass the data from multiple viewController. We will learn few more ways to do that.
When you go back from Setting page, you load the default tip percentage in viewDidAppear. Think of it, should it be viewViewAppear? You want to load everything before it shows up to the user.
I see you remember the data after app restart, but you haven't implemented the 10 mins, have you? Look at the NSDate() to calculate the time. Think of the reason why we ask to save only within 10min.
You shouldn't let the user enter invalid number, should you? I can enter bunch of leading zeros and decimal points. And when your app first run, it show 0 in the bill amount. When I keep typing there will be a leading zero.
Nice animation in setting page.
Instead of do ... catch ... you can use if let to ensure your data is not nil before you can do something with it.
In you notice in your code, xcode reminds few times to use let instead of var for the constant.
Thanks for your submission. Everything looks good with that. We'll review it and get back to you soon :)
The text was updated successfully, but these errors were encountered: