Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BatonId #134

Open
FKD13 opened this issue Apr 2, 2024 · 1 comment
Open

Remove BatonId #134

FKD13 opened this issue Apr 2, 2024 · 1 comment
Labels
database It's, uh, where we store data. difficulty:medium enhancement New feature or request

Comments

@FKD13
Copy link
Member

FKD13 commented Apr 2, 2024

The Mac is enough to identify a baton. Having a BatonId only adds complexity in this case.

The fetcher needs to keep a map in memory of the mac to batonId mapping. This should not be needed.
For the batonswitchovers the batonId is also used. Using a MAC here would not be more usefull, but here we can switch to batonLabel (which should also be unique) and this would be an improvement, as it is very clear which physical baton is assigned to the team from the switchover

This change can be difficult becouse the batonId is used in a couple of places outside telraam as well. Currently in https://github.com/12urenloop/Loxsi and https://github.com/12urenloop/DeDenker

@FKD13 FKD13 added enhancement New feature or request difficulty:medium database It's, uh, where we store data. labels Apr 2, 2024
@FKD13 FKD13 added this to 12UL 23-24 Apr 2, 2024
@FKD13
Copy link
Member Author

FKD13 commented Apr 2, 2024

So roughly like this:

Detection{...} ------ MAC -------> Baton{MAC, LABEL} <--------- LABEL --------- BatonSwitchover{Prev: Label, Next: Label}
Detection{Mac: 00:00:00:00:00:00}
Detection{Mac: 00:00:00:00:00:01}

Baton{Mac: 00:00:00:00:00:00, Label: 'A'}
Baton{Mac: 00:00:00:00:00:01, Label: 'B'}

BatonSwitchover{Team: 'LeTeam', Prev: 'A', Next: 'B'}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
database It's, uh, where we store data. difficulty:medium enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant