Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop sending data when freeze time hits #16

Open
Topvennie opened this issue Apr 8, 2024 · 2 comments
Open

Stop sending data when freeze time hits #16

Topvennie opened this issue Apr 8, 2024 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Topvennie
Copy link
Member

Previously Loxsi stopped sending new information to the websocket clients after a specified freeze time.
This feature needs to be added again

@Topvennie Topvennie added bug Something isn't working good first issue Good for newcomers labels Apr 8, 2024
@FKD13
Copy link
Member

FKD13 commented Apr 20, 2024

This is partially implemented. Lap counts are Ok. Positioner data is still sent

@redfast00 redfast00 changed the title Stop sending data when freetime hits Stop sending data when freeze time hits Apr 24, 2024
@redfast00
Copy link
Member

  • de livesite op de ledwall was niet helemaal bevroren nadat de positioner op frozen gezet was:
    • oorzaken:
      • de livesite deed 'optimistic updates' (dus als de position groter is dan 1, dan werd er 1 bij de laps geteld)
      • loxsi had een cache van position-data, die ook werd gestuurd als het scorebord frozen is
      • de livesite bleef oneindig lang extrapoleren aan de hand van de laatste positiedata
    • suggested fixes (meerdere):
      • timeout zetten op hoe lang er mag ge-extrapoleerd worden op bepaalde data
      • de cache leegmaken als het scoreboard frozen is, en niet meer vullen
      • zeker zijn dat er geen positioner data meer in de cache komt als frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Status: Todo
Development

No branches or pull requests

3 participants