Skip to content
This repository has been archived by the owner on May 2, 2022. It is now read-only.

Is TenUpScaffold\ Overrides\setup(); missing on purpose #195

Open
samikeijonen opened this issue Aug 17, 2020 · 2 comments
Open

Is TenUpScaffold\ Overrides\setup(); missing on purpose #195

samikeijonen opened this issue Aug 17, 2020 · 2 comments
Assignees

Comments

@samikeijonen
Copy link
Contributor

Is your enhancement related to a problem? Please describe.
Is TenUpScaffold\ Overrides\setup(); missing on purpose in functions.php file?

Describe the solution you'd like

  • If it's missing on purpose, should we add it as comment in functions.php file so it would be easier to remember.
  • If it's not missing on purpose, can we add it.
  • I might also be missing something :)
@dainemawer
Copy link
Contributor

@samikeijonen I originally suggested / implemented these overrides (long ago) - I also noticed that its not called by default on build a few weeks ago. I think a comment is a good idea for now. It would be cleaner to perhaps implement something similar to add_theme_support( 'theme-overrides' ); considering it adds additional functionality to the theme. Open to opinion though!

@dainemawer
Copy link
Contributor

@samikeijonen @timwright12 this is not the first time that this issue has been brought up: #151

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants