Remove eslint from webpack.

[nicholasio]

Is your enhancement related to a problem? Please describe.

Currently, webpack will not compile the code if eslint fails. I think this isn't necessary since the scaffold already has the precommit hook and based on my experience preventing webpack compilation when eslint fails is a source of confusion.

The precommit hook is a much better place to do those checks and it would act as the last barrier to prevent engineers from pushing code that does not adhere to our eslint.

Additionally, vscode and most IDEs have really good integrations with linting tools and engineers should also be setting those integrations up for a much better experience.

Describe the solution you'd like

Remove

			// Lint JS.
			{
				test: /\.js$/,
				exclude: /node_modules/,
				enforce: 'pre',
				loader: 'eslint-loader',
				options: {
					fix: true,
				},
			},

from webpack.common.js

Designs

Describe alternatives you've considered

Additional context

[jeffpaul]

@timwright12 any thoughts on @nicholasio's proposal to remove eslint from webpack?

[samikeijonen]

+1 from me.