Skip to content
This repository has been archived by the owner on Apr 28, 2021. It is now read-only.

Incorrect entry file in package.json #8

Closed
ivankruchkoff opened this issue Apr 13, 2020 · 3 comments
Closed

Incorrect entry file in package.json #8

ivankruchkoff opened this issue Apr 13, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@ivankruchkoff
Copy link

Describe the bug
Incorrect entry file in JS, links to src, but should use transpiled version in dist.
https://github.com/10up/component-reading-position/blob/8ce30e9/package.json#L6

Causing this issue in downstream dependencies: 10up/theme-scaffold#183
@ivankruchkoff ivankruchkoff added the bug Something isn't working label Apr 13, 2020
@fabiankaegy fabiankaegy mentioned this issue Apr 14, 2020
Closed
@timwright12
Copy link
Contributor

@fabiankaegy this one can be fixed since we haven't released yet

@fabiankaegy
Copy link
Member

@timwright12 I have created the PR for it #9

@timwright12
Copy link
Contributor

@fabiankaegy this will need to be testing, see my comment in the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ivankruchkoff @timwright12 @nicholasio @fabiankaegy