Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private channel names are sent out publicly through websocket when being removed #159

Open
Kelton555 opened this issue Sep 13, 2024 · 0 comments

Comments

@Kelton555
Copy link

Private channel names get sent out publicly on the websocket when being removed; i.e. when the last user disconnects or joins a different channel. Disconnecting is of particular importance as people will rejoin the same private channel when they next reconnect, potentially leading to the leakage of private channels that are still in use.

The cause is the hard-coded 'false' here:

BroadcastCMD(false, "chan_remove",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant